MarcSync/roblox-client
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Migrating Endpoints to V1 #29

Closed
IBims2CooleTim wants to merge 2 commits from feature/filters into dev
pull from: feature/filters
merge into: MarcSync:dev
Conversation 8 Commits 2 Files Changed 4 +32 -12
IBims2CooleTim commented 2023-12-16 03:34:57 +00:00 (Migrated from github.com)
Copy Link
  • Changed Endpoints to v1
- Changed Endpoints to v1
WhenUHackUNoob (Migrated from github.com) reviewed 2023-12-16 03:34:57 +00:00
bidzanaaron (Migrated from github.com) reviewed 2023-12-16 03:34:57 +00:00
Nathan-b3nt (Migrated from github.com) reviewed 2023-12-16 03:34:57 +00:00
Jimmysaville (Migrated from github.com) reviewed 2023-12-16 03:34:57 +00:00
MarciiTheDev (Migrated from github.com) reviewed 2023-12-16 03:34:57 +00:00
vercel[bot] commented 2023-12-16 03:35:02 +00:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marcsync-rbx-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 8:42pm
[vc]: #om3oKbR3vwxFD3/kLuwvTcIIBsOrRbmf3yIqpehXJ78=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJtYXJjc3luYy1yYngtY2xpZW50IiwiaW5zcGVjdG9yVXJsIjoiaHR0cHM6Ly92ZXJjZWwuY29tL21hcmNpaXRoZWRldi9tYXJjc3luYy1yYngtY2xpZW50LzNXclBiajVlNmpGV1R0SndDUlJVTlNOS3I4S3oiLCJwcmV2aWV3VXJsIjoibWFyY3N5bmMtcmJ4LWNsaWVudC1naXQtZmVhdHVyZS1maWx0ZXJzLW1hcmNpaXRoZWRldi52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIiwicm9vdERpcmVjdG9yeSI6IndlYnNpdGUvZG9jcy1tYXJjc3luYy1kZXYiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoibWFyY3N5bmMtcmJ4LWNsaWVudC1naXQtZmVhdHVyZS1maWx0ZXJzLW1hcmNpaXRoZWRldi52ZXJjZWwuYXBwIn19XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marcsync-rbx-client** | ✅ Ready ([Inspect](https://vercel.com/marciithedev/marcsync-rbx-client/3WrPbj5e6jFWTtJwCRRUNSNKr8Kz)) | [Visit Preview](https://vercel.live/open-feedback/marcsync-rbx-client-git-feature-filters-marciithedev.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/marcsync-rbx-client-git-feature-filters-marciithedev.vercel.app?via=pr-comment-feedback-link) | Dec 21, 2023 8:42pm |
MarciiTheDev (Migrated from github.com) requested changes 2023-12-17 18:16:16 +00:00
MarciiTheDev (Migrated from github.com) left a comment
Copy Link

Wrong implementation of PUT https://api.marcsync.dev/v1/entries/{collectionName}
Wrong implementation of PATCH https://api.marcsync.dev/v1/entries/{collectionName}/methodOverwrite=GET
Wrong implementation of DELETE https://api.marcsync.dev/v1/entries/{collectionName}

type "FilterData" does not match API FilterData

Implementation of the changes do not work and have no effect

Please refer/test out the code before committing update on PR

Wrong implementation of PUT https://api.marcsync.dev/v1/entries/{collectionName} Wrong implementation of PATCH https://api.marcsync.dev/v1/entries/{collectionName}/methodOverwrite=GET Wrong implementation of DELETE https://api.marcsync.dev/v1/entries/{collectionName} type "FilterData" does not match API FilterData Implementation of the changes do not work and have no effect Please refer/test out the code before committing update on PR
MarciiTheDev commented 2024-05-10 09:37:48 +00:00 (Migrated from github.com)
Copy Link

Missing documentation, more user-friendly integration for FilterData possible

Missing documentation, more user-friendly integration for FilterData possible

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
WhenUHackUNoob
bidzanaaron
Nathan-b3nt
Jimmysaville
MarciiTheDev
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MarcTheDev Scr1ptxdEthxn
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarcSync/roblox-client#29
No description provided.
Delete Branch "feature/filters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?