MarcSync/roblox-client
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fixed a few small spelling errors #14

Merged
IBims2CooleTim merged 17 commits from main into main 2023-10-01 00:07:44 +00:00
Conversation 19 Commits 17 Files Changed 14 +193 -193
IBims2CooleTim commented 2023-09-30 21:30:56 +00:00 (Migrated from github.com)
Copy Link
No description provided.
Nathan-b3nt (Migrated from github.com) reviewed 2023-09-30 21:30:56 +00:00
vercel[bot] commented 2023-09-30 21:30:59 +00:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marcsync-rbx-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 10:42pm
[vc]: #xdxjM1LTVhIo72UTJpDxZz9C7TThT7kedQvDM3pFtEM=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJtYXJjc3luYy1yYngtY2xpZW50Iiwicm9vdERpcmVjdG9yeSI6IndlYnNpdGUvZG9jcy1tYXJjc3luYy1kZXYiLCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vbWFyY2lpdGhlZGV2L21hcmNzeW5jLXJieC1jbGllbnQvMlhvYU1nMWtKb0JHcDRpTFdTUDhQU0F3blFTdSIsInByZXZpZXdVcmwiOiJtYXJjc3luYy1yYngtY2xpZW50LWdpdC1mb3JrLWliaW1zMmNvb2xldGltLW1haW4tbWFyY2lpdGhlZGV2LnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoibWFyY3N5bmMtcmJ4LWNsaWVudC1naXQtZm9yay1pYmltczJjb29sZXRpbS1tYWluLW1hcmNpaXRoZWRldi52ZXJjZWwuYXBwIn19XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marcsync-rbx-client** | ✅ Ready ([Inspect](https://vercel.com/marciithedev/marcsync-rbx-client/2XoaMg1kJoBGp4iLWSP8PSAwnQSu)) | [Visit Preview](https://vercel.live/open-feedback/marcsync-rbx-client-git-fork-ibims2cooletim-main-marciithedev.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/marcsync-rbx-client-git-fork-ibims2cooletim-main-marciithedev.vercel.app?via=pr-comment-feedback-link) | Sep 30, 2023 10:42pm |
WhenUHackUNoob commented 2023-09-30 22:03:41 +00:00 (Migrated from github.com)
Copy Link

review

review
👍 3 ❤️ 1
bidzanaaron (Migrated from github.com) reviewed 2023-09-30 22:05:02 +00:00
src/MarcSync/Objects/Collection.lua
bidzanaaron (Migrated from github.com) commented 2023-09-30 22:04:33 +00:00
Copy Link

I would like to acknowledge the recent changes in the code, particularly with regard to the EntryData function. It is extremely gratifying to see how efficient and optimized this function has become. Working on improving resource efficiency is of paramount importance, and your recent adjustments in this regard deserve special recognition. Your efforts have undoubtedly contributed significantly to enhancing the overall performance of the code. Thank you very much for your dedication and outstanding work in this matter.

Ich möchte die jüngsten Änderungen im Code bemerken, insbesondere in Bezug auf die EntryData-Funktion. Es ist äußerst erfreulich zu sehen, wie effizient und optimiert diese Funktion jetzt ist. Die Arbeit an der Verbesserung der Ressourceneffizienz ist von höchster Bedeutung, und Ihre jüngsten Anpassungen in dieser Hinsicht verdienen besondere Anerkennung. Ihre Bemühungen haben zweifellos dazu beigetragen, die Gesamtleistung des Codes erheblich zu steigern. Vielen Dank für Ihr Engagement und Ihre hervorragende Arbeit in dieser Angelegenheit.

I would like to acknowledge the recent changes in the code, particularly with regard to the EntryData function. It is extremely gratifying to see how efficient and optimized this function has become. Working on improving resource efficiency is of paramount importance, and your recent adjustments in this regard deserve special recognition. Your efforts have undoubtedly contributed significantly to enhancing the overall performance of the code. Thank you very much for your dedication and outstanding work in this matter. Ich möchte die jüngsten Änderungen im Code bemerken, insbesondere in Bezug auf die EntryData-Funktion. Es ist äußerst erfreulich zu sehen, wie effizient und optimiert diese Funktion jetzt ist. Die Arbeit an der Verbesserung der Ressourceneffizienz ist von höchster Bedeutung, und Ihre jüngsten Anpassungen in dieser Hinsicht verdienen besondere Anerkennung. Ihre Bemühungen haben zweifellos dazu beigetragen, die Gesamtleistung des Codes erheblich zu steigern. Vielen Dank für Ihr Engagement und Ihre hervorragende Arbeit in dieser Angelegenheit.
IBims2CooleTim commented 2023-09-30 22:05:34 +00:00 (Migrated from github.com)
Copy Link

thank you dear sir.

thank you dear sir.
MarciiTheDev (Migrated from github.com) reviewed 2023-09-30 22:06:09 +00:00
src/MarcSync/Objects/Collection.lua
MarciiTheDev (Migrated from github.com) commented 2023-09-30 22:06:09 +00:00
Copy Link

I can really understand this point, and can only just reflect it for my review too.

I can really understand this point, and can only just reflect it for my review too.
MarciiTheDev commented 2023-09-30 22:09:03 +00:00 (Migrated from github.com)
Copy Link

Just... Why?

Just... Why?
IBims2CooleTim commented 2023-09-30 22:09:08 +00:00 (Migrated from github.com)
Copy Link

yes

[**yes**](https://www.youtube.com/watch?v=dQw4w9WgXcQ&pp=ygUjcmljayBhc3RsZXkgbmV2ZXIgZ29ubmEgZ2l2ZSB5b3UgdXA%3D)
MarciiTheDev commented 2023-09-30 22:10:34 +00:00 (Migrated from github.com)
Copy Link

yes

can't really understand this point, but it seems to be important to you. Maybe it has a deep background story or smth. to do with your mental illness or paranoia or psychopathic behaviour in order for you to come up and do this pull request.

> [**yes**](https://www.youtube.com/watch?v=dQw4w9WgXcQ&pp=ygUjcmljayBhc3RsZXkgbmV2ZXIgZ29ubmEgZ2l2ZSB5b3UgdXA%3D) can't really understand this point, but it seems to be important to you. Maybe it has a deep background story or smth. to do with your mental illness or paranoia or psychopathic behaviour in order for you to come up and do this pull request.
MarciiTheDev (Migrated from github.com) approved these changes 2023-09-30 22:10:53 +00:00
MarciiTheDev (Migrated from github.com) left a comment
Copy Link

Yeah, why not.

Yeah, why not.
bidzanaaron (Migrated from github.com) reviewed 2023-09-30 22:13:59 +00:00
bidzanaaron (Migrated from github.com) left a comment
Copy Link

Very well done sir.

Very well done sir.
WhenUHackUNoob (Migrated from github.com) reviewed 2023-09-30 22:31:10 +00:00
WhenUHackUNoob (Migrated from github.com) left a comment
Copy Link

ich bin Josh

ich bin Josh
MarciiTheDev (Migrated from github.com) requested changes 2023-09-30 22:31:18 +00:00
MarciiTheDev (Migrated from github.com) left a comment
Copy Link

Change every mention of collection to sammlung

Change every mention of collection to sammlung
MarciiTheDev (Migrated from github.com) reviewed 2023-09-30 22:33:39 +00:00
MarciiTheDev (Migrated from github.com) left a comment
Copy Link

fuck it, who cares anyways

fuck it, who cares anyways
MarciiTheDev (Migrated from github.com) approved these changes 2023-09-30 22:48:50 +00:00
MarciiTheDev (Migrated from github.com) left a comment
Copy Link

damn, even the queen england would be proud of you

damn, even the queen england would be proud of you
bidzanaaron (Migrated from github.com) approved these changes 2023-09-30 22:49:20 +00:00
Jimmysaville (Migrated from github.com) approved these changes 2023-10-01 00:07:01 +00:00
Jimmysaville (Migrated from github.com) left a comment
Copy Link

I like little kids

I like little kids
WhenUHackUNoob commented 2023-10-01 14:27:49 +00:00 (Migrated from github.com)
Copy Link

no

no
MarciiTheDev commented 2023-10-01 14:39:42 +00:00 (Migrated from github.com)
Copy Link

too late to change

too late to change
Sign in to join this conversation.
Reviewers
No Reviewers
Nathan-b3nt
MarciiTheDev
bidzanaaron
Jimmysaville
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
MarcTheDev Scr1ptxdEthxn
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MarcSync/roblox-client#14
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?